Skip to content

Fix noexcept and constraints on value_or() and error_or() #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
CaptainNeil merged 3 commits into from
Apr 16, 2024
Merged

Fix noexcept and constraints on value_or() and error_or() #3

CaptainNeil merged 3 commits into from
Apr 16, 2024

Conversation

@X1aomu
Copy link
Contributor

@X1aomu X1aomu commented Apr 16, 2024

This PR fix #2 and some constraints issues about value_or() / error_or().

@X1aomu X1aomu added the bug Something isn't working label Apr 16, 2024
@X1aomu X1aomu self-assigned this Apr 16, 2024
@X1aomu X1aomu requested a review from CaptainNeil April 16, 2024 08:18
@CaptainNeil CaptainNeil merged commit ba8c1bb into main Apr 16, 2024
@X1aomu X1aomu deleted the fix-noexcept-and-constraints branch April 16, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@CaptainNeil CaptainNeil CaptainNeil approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@X1aomu X1aomu

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

noexcept specifiers on valur_or() and error_or() not work in C++17

3 participants

@X1aomu @CaptainNeil